[Buildroot] [Bug 13586] New: grub failure with BR2_OPTIMIZE_3
Yann E. MORIN
yann.morin.1998 at free.fr
Fri Jun 4 20:52:07 UTC 2021
Andreas, All,
On 2021-05-31 12:22 +0200, Andreas Hilse via buildroot spake thusly:
> > So, maybe things have changed from way back when we wrote that comment
> > (back in 2014, seven years ago!), or maybe we did not undestand all of
> > it, or maybe we did not explain it properly, or a bit of all of that...
> >
> > In any case, we might want to also override CFLAGS and CPPFLAGS in the
> > same vein as the above patch does for TARGET_CFLAGS et al.
> >
> > Care to have a look at that, see if it fixes the issue, and you can get
> > a bootable grub2, please?
>
> Additionally overriding CFLAGS and CPPFLAGS results in a bootable grub2.
>
> diff --git a/boot/grub2/grub2.mk b/boot/grub2/grub2.mk
> index af16ee91e1..52e9199ae9 100644
> --- a/boot/grub2/grub2.mk
> +++ b/boot/grub2/grub2.mk
> @@ -118,9 +118,11 @@ HOST_GRUB2_CONF_ENV = \
> GRUB2_CONF_ENV = \
> CPP="$(TARGET_CC) -E" \
> TARGET_CC="$(TARGET_CC)" \
> - TARGET_CFLAGS="$(TARGET_CFLAGS)" \
> - TARGET_CPPFLAGS="$(TARGET_CPPFLAGS) -fno-stack-protector" \
> - TARGET_LDFLAGS="$(TARGET_LDFLAGS)" \
> + CFLAGS="$(TARGET_CFLAGS) -Os" \
> + TARGET_CFLAGS="$(TARGET_CFLAGS) -Os" \
> + CPPFLAGS="$(TARGET_CPPFLAGS) -Os -fno-stack-protector" \
> + TARGET_CPPFLAGS="$(TARGET_CPPFLAGS) -Os -fno-stack-protector" \
> + TARGET_LDFLAGS="$(TARGET_LDFLAGS) -Os" \
> TARGET_NM="$(TARGET_NM)" \
> TARGET_OBJCOPY="$(TARGET_OBJCOPY)" \
> TARGET_STRIP="$(TARGET_CROSS)strip"
Thanks for the feedback. Could you submit a proper patch, with an actual
commit log (title, body with a summary of this thread, and your SoB-line),
please?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list