[Buildroot] [PATCHv4 11/16] package/sofia-sip: correct passing of '--enable-ndebug'

Thomas De Schampheleire patrickdepinguin at gmail.com
Tue Jun 1 14:34:16 UTC 2021


From: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>

The preprocessor option NDEBUG, triggered by the configure option
'--enable-ndebug', should be read as 'no-debug'. When NDEBUG is set, asserts
are _disabled_.

The sofia-sip package had inverted logic, and set '--enable-ndebug' when
BR2_ENABLE_DEBUG was enabled, while it should be the other way around.

Reported-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
---
v4: new patch;
Even though the next patch will remove this block altogether, I keep this
correction as a separate patch to make it clear that the original code was
incorrect, and allow potential backporting to other branches.

 package/sofia-sip/sofia-sip.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/sofia-sip/sofia-sip.mk b/package/sofia-sip/sofia-sip.mk
index 5c383400ff..274c72fce8 100644
--- a/package/sofia-sip/sofia-sip.mk
+++ b/package/sofia-sip/sofia-sip.mk
@@ -30,7 +30,7 @@ SOFIA_SIP_CONF_OPTS += \
 	--without-openssl
 endif
 
-ifeq ($(BR2_ENABLE_DEBUG),y)
+ifeq ($(BR2_ENABLE_DEBUG),)
 SOFIA_SIP_CONF_OPTS += --enable-ndebug
 endif
 
-- 
2.26.3




More information about the buildroot mailing list