[Buildroot] [PATCH v2, 1/2] package/libkrb5: add openssl optional dependency
Yann E. MORIN
yann.morin.1998 at free.fr
Sun Jun 13 20:02:23 UTC 2021
Fabrice, All,
On 2021-06-13 18:41 +0200, Fabrice Fontaine spake thusly:
> Le dim. 13 juin 2021 à 18:08, Yann E. MORIN <yann.morin.1998 at free.fr> a écrit :
> > On 2021-06-13 11:10 +0200, Fabrice Fontaine spake thusly:
> > > openssl is an optional dependency which is enabled by default since at
> > > least 2007 and
> > > https://github.com/krb5/krb5/commit/4c17f25c0f106ec8e3aad2cee4e7a24f66b5a65d
> > >
> > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> > I squashed the two commits together, because selecting the openssl
> > options is really just part of fixing the openssl dependency of libkrb5.
> Perhaps, it would have been better to keep them separate as Peter will
> probably only want to backport the first patch to 2020.xx and 2021.xx
> branches?
That's true.
However, semantically, I still believe the two patches should really
have been one, because if we don't select the options when we explicitly
add the openssl depenency, then we are still introducing a failure.
And I don't think that it is unreasonable to expect that some commits
have to be adapted when backported.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list