[Buildroot] [PATCH 1/1] package/weston: disable -NDEBUG

[James Hilliard]

On Wed, Jun 16, 2021 at 2:09 PM Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>
> James, All,
>
> On 2021-06-16 13:48 -0600, James Hilliard spake thusly:
> > On Wed, Jun 16, 2021 at 1:22 PM Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> > > On 2021-06-14 18:55 -0600, James Hilliard spake thusly:
> > > > Fixes:
> > > > http://autobuild.buildroot.net/results/f42/f420890de1b52786f8cf5f2922b69c909162eaa1/
> > >
> > > It is just tests that can't be built with -DNDEBUG. It would be a shame
> > > to have to build the whole thing without NDEBUG, just becuase of tests
> > > that are not usefull on the target...
> > Per upstream weston should not be built with -DNDEBUG since
> > weston relies on asserts for non-tests as well to catch certain fatal
> > conditions.
>
> That info should have been in the commit log. A pointer to upstream
> discussion about it would be a bonus.
>
> Can you respoin the patch, please?

https://patchwork.ozlabs.org/project/buildroot/patch/20210616201711.1131369-1-james.hilliard1@gmail.com/

>
> > > Is it possible to just disable building tests at all? Or if not, can't
> > > we just patch them out?
> > We could...however upstream recommended not to do that as it can make
> > tracing certain errors extremely difficult.
>
> OK, but having a way to disable tests would still be good, because
> basically, tests are useless on a product.

Yeah, there's some pending PR's that would make that possible, see:
https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/555
https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/642

>
> Regards,
> Yann E. MORIN.
>
> > >
> > > Regards,
> > > Yann E. MORIN.
> > >
> > > > Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
> > > > ---
> > > >  package/weston/weston.mk | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/package/weston/weston.mk b/package/weston/weston.mk
> > > > index 8afe4bbab4..abafb3a6d9 100644
> > > > --- a/package/weston/weston.mk
> > > > +++ b/package/weston/weston.mk
> > > > @@ -19,6 +19,8 @@ WESTON_CONF_OPTS = \
> > > >       -Dcolor-management-colord=false \
> > > >       -Dremoting=false
> > > >
> > > > +WESTON_CFLAGS="$(TARGET_CFLAGS) -UNDEBUG"
> > > > +
> > > >  # Uses VIDIOC_EXPBUF, only available from 3.8+
> > > >  ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8),y)
> > > >  WESTON_CONF_OPTS += -Dsimple-clients=dmabuf-v4l
> > > > --
> > > > 2.25.1
> > > >
> > > > _______________________________________________
> > > > buildroot mailing list
> > > > buildroot at busybox.net
> > > > http://lists.busybox.net/mailman/listinfo/buildroot
> > >
> > > --
> > > .-----------------.--------------------.------------------.--------------------.
> > > |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> > > | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> > > | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> > > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> > > '------------------------------^-------^------------------^--------------------'
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'