[Buildroot] [PATCH for-next 1/2] package/gdb: enable gdbserver support for riscv

Romain Naour romain.naour at gmail.com
Thu Jun 17 21:08:45 UTC 2021


Hello Alistair, Arnout, All,

Le 15/06/2021 à 10:07, Alistair Francis a écrit :
> On Mon, Jun 14, 2021 at 2:33 AM Arnout Vandecappelle <arnout at mind.be> wrote:
>>
>>
>>
>> On 13/06/2021 12:54, Romain Naour wrote:
>>> Hello Arnout,
>>>
>>> Le 13/06/2021 à 12:19, Arnout Vandecappelle a écrit :
>>>>
>>>>
>>>> On 06/06/2021 17:03, Romain Naour wrote:
>>>>> It turn out that gdbserver support for riscv is available since 10.1 release, since commit [1]
>>>>>
>>>>> When BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTS is not enabled, gdb will use the stable version (9.x)
>>>>> where gdbserver for riscv is not available.
>>>>>
>>>>> When BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTS enabled, only allow gdb 10.1 in version choice and
>>>>> allow enabling gdbserver for the target.
>>>>
>>>>  Instead of all this complexity, I think it would be easier to just force gdb to
>>>> version 10 on riscv:
>>>>
>>>> config BR2_GDB_VERSION
>>>>         string
>>>>         default "arc-2020.09-release-gdb" if BR2_arc
>>>>         default "4ecb98fbc2f94dbe01b69384afbc515107de73df" if BR2_csky
>>>>         default "8.3.1"    if BR2_GDB_VERSION_8_3
>>>>         default "9.2"      if BR2_GDB_VERSION_9_2 || (!BR2_PACKAGE_HOST_GDB &&
>>>> !BR2_riscv)
>>>>         default "10.1"     if BR2_GDB_VERSION_10 || (!BR2_PACKAGE_HOST_GDB &&
>>>> BR2_riscv)
>>>>         depends on BR2_PACKAGE_GDB || BR2_PACKAGE_HOST_GDB
>>>>
>>>>  IMHO that will make the maintainance easier going forward: when 10 becomes the
>>>> default, we can simply drop the riscv condition and nothing more needs to be done.
>>>
>>> I was not sure about restrict the gdb version for riscv just because gdb 10.1
>>> can provide gdbserver.
>>
>>  Wow, hang on, I apparently misunderstood something here...
>>
>>  Now I see... It's just gdbserver that wasn't available before 10.1.
>> gdb-on-target was already available.. In that case, my simplification doesn't
>> apply indeed.
>>
>>  Although... My suggestion just means that for riscv, we always use gdb 10.1 (on
>> target) instead of gdb 9. I don't see a big problem with that. Note that for gdb
>> for target, we never had a version selection. So the only thing that happens is
>> that riscv now already uses a gdb 10 on target, while the rest will only start
>> using gdb 10 on target a few months from now when gdb 11 is released. Honestly,
>> I think that's fine.
> 
> Agreed. I think it's best to just support GDB 10.1.
> 
>>
>>  Regards,
>>  Arnout
>>
>>>
>>> Alistair, is it ok for you if we only provide gdb 10.1 ?
> 
> Yep! I think that's the best plan of action here. From memory GDB 10.1
> has some useful fixes for RISC-V anyway.

Ok, thanks for the feedback.

Best regards,
Romain


> 
> Alistair
> 
>>>
>>> Best regards,
>>> Romain
>>>
>>>
>>>>
>>>>  Marked as Changes Requested.
>>>>
>>>>  Regards,
>>>>  Arnout
>>>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot




More information about the buildroot mailing list