[Buildroot] [PATCH] package/links: enable building graphics mode with only fb driver

Urja Rannikko urjaman at gmail.com
Fri May 14 09:26:45 UTC 2021


Hi,

On Wed, May 5, 2021 at 11:08 PM Arnout Vandecappelle <arnout at mind.be> wrote:
>
>  Still not good enough, I'm afraid :-) You also need to depend on gpm in the .mk
> file.
>
It already does, atleast that's how i read this fragment in links.mk:

ifeq ($(BR2_PACKAGE_GPM),y)
LINKS_CONF_OPTS += --with-gpm
LINKS_DEPENDENCIES += gpm
else
LINKS_CONF_OPTS += --without-gpm
endif

And yes links can use GPM in textmode-only build too, so that seems
correct as-is.

>  Also, I'm thinking: maybe we can turn this around and automatically select gpm?
>
>         select BR2_PACKAGE_GPM if !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7
>
>  That way you don't need the comment either. Well, you still do because gpm
> depends on static:
>
>         depends on !BR2_STATIC_LIBS if !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7 # gpm
>
> so the comment would become:
>
> comment "links graphics needs dynamic libs, DirectFB or X11"
>         depends on BR2_STATIC_LIBS && !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7
>

I have no hard opinion on this, except that I do dislike possibly
non-obvious use of select
(and it has the dependency trouble you listed), which would leave GPM
selected if one
toggled links graphics on and off while using menuconfig.

-- 
Urja Rannikko



More information about the buildroot mailing list