[Buildroot] [PATCH] support/testing: fix python_flask_expect_python
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Wed Oct 6 20:44:13 UTC 2021
On Wed, 6 Oct 2021 22:38:23 +0200
"Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:
> Commit e6ee07f41a2b (package/python-flask-expects-json: new package)
> added a non-functional test case that, as noticed by Edgar, fails with:
>
> AssertionError: '%{http_code}' != '200'
>
> That's because the % sign is self-escaped, à-la C, in the first part
> of the command, probably to avoid its being %-formatted. But only the
> second part of the command is %-formatted, so we do not need to
> self-escape % in the first part.
Gaah, seemingly innocent-looking last minute (untested) refactoring is
ALWAYS wrong. Sorry about this and thanks for fixing my crap.
> Additionally, since eb3ee3078a76 (support/testing/infra/emulator.py:
> prevent the commands from wrapping), we no longer need to play tricks
> with commands that are too long to fit on the first line of the shell
> prompt.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Edgar Bonet <bonet at grenoble.cnrs.fr>
Looks good:
Reviewed-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
More information about the buildroot
mailing list