[Buildroot] [PATCH 1/1] package/pecl-dbus: new package

[Thomas Petazzoni]

Hello,

On Tue, 5 Oct 2021 18:15:23 +0200
Herve Codina <herve.codina at bootlin.com> wrote:

> > Thanks for this new package. I'm just wondering about the package name.
> > The upstream project is indeed named pecl-dbus, where pecl stands for
> > "PHP Extension Community Library". But all our other PHP packages are
> > named "php-<something>". Should we name this package "php-dbus" ?
> > "php-pecl-dbus" ?  
> 
> "php-pecl-dbus" sounds good.
> If it's ok for everyone, I will change in v2.

Fine with me. As said, I'm fine with either php-dbus or php-pecl-dbus.

> > > +Signed-off-by: Herve Codina <herve.codina at bootlin.com>    
> > 
> > And submit this upstream ?  
> 
> I did too.

👍

> > I was wondering if you need both BR2_PACKAGE_LIBXML2 and
> > BR2_PACKAGE_PHP_EXT_LIBXML2, i.e does pecl-dbus link directly with the
> > libxml2 native library ?  
> 
> libxml2 is needed. In dbus.c source file, we have
>   #include "libxml/parser.h"
>   #include "libxml/parserInternals.h"
> and calls to libxml2 functions such as 'xmlParseMemory()'

So, confirms that it links with libxml2 directly, indeed!

> > pecl-dbus can build without dbus ?!?  
> 
> Indeed, '--enable-dbus' is not needed and will be removed in v2.

ACK, perfect.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com