[Buildroot] [PATCH] package/mesa3d: remove unnecessary passing of CFLAGS
Peter Korsgaard
peter at korsgaard.com
Sat Oct 9 11:46:54 UTC 2021
>>>>> "Giulio" == Giulio Benetti <giulio.benetti at benettiengineering.com> writes:
> This package uses meson-package infrastracture, so we don't need to
> explicitly pass its additional CFLAGS to some variable. The only thing we
> need to pass them is to use MESA3D_CFLAGS, because in package/pkg-meson.mk
> we have:
> $(2)_CFLAGS ?= $$(TARGET_CFLAGS)
> that makes the work automatically, where $(2) is exactly the package name,
> though $(2)_CFLAGS expands to MESA3D_CFLAGS.
> So let's remove the MESA3D_CONF_OPTS += -DCMAKE_C_FLAGS="$(MESA3D_CFLAGS)"
> line that has been added by mistake.
> Note: this doesn't fix any bug, but remove an unnecessary and ambiguos line
> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
Committed to 2021.02.x, 2021.05.x and 2021.08.x, thanks (together with
'package/mesa3d: fix build on m68k').
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list