[Buildroot] [git commit] package/kmsxx: remove erroneous use of static-libc option

Yann E. MORIN yann.morin.1998 at free.fr
Sat Sep 4 18:25:21 UTC 2021


commit: https://git.buildroot.net/buildroot/commit/?id=95ad161fe933b01986b426c47f019d58900d62a2
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Currently, for a static-only build, we pass -Dstatic-libc=true. The
reason for that was not recorded when the package was converted to
meson.

The -Dstatic-libc=true option, despite its name, is not about linking
statically against libc, but against libgcc and libstdc++.

In Buildroot, we forcibly pass -static when calling the compiler and
linker, so everything is already linked statically.

For a shared build, -Dstatic-libc=false has no effect at all.

Drop this option altogether, as it is not needed, and is confusing.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
[yann.morin.1998 at free.fr: expand commit log]
Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>
---
 package/kmsxx/kmsxx.mk | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/package/kmsxx/kmsxx.mk b/package/kmsxx/kmsxx.mk
index fd40ff8e73..871ecaf85c 100644
--- a/package/kmsxx/kmsxx.mk
+++ b/package/kmsxx/kmsxx.mk
@@ -17,12 +17,6 @@ KMSXX_CONF_OPTS = \
 	-Duse-system-fmt=true \
 	-Duse-system-pybind11=true
 
-ifeq ($(BR2_STATIC_LIBS),y)
-KMSXX_CONF_OPTS += -Dstatic-libc=true
-else
-KMSXX_CONF_OPTS += -Dstatic-libc=false
-endif
-
 ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
 KMSXX_CXXFLAGS += $(TARGET_CXXFLAGS) -O0
 endif


More information about the buildroot mailing list