[Buildroot] [PATCH 1/1] package/minicom: drop autoreconf

Giulio Benetti giulio.benetti at benettiengineering.com
Sun Sep 12 21:09:55 UTC 2021


Hi Fabrice,

On 9/12/21 10:07 PM, Fabrice Fontaine wrote:
> autoreconf (and so AM_ICONV) is not needed since commit
> 2df32e0d4437b422175089edf1917219656fccef

Can you specify the upstream commit instead of the Buildroot one in 
commit log?

Except that:

Reviewed-by: Giulio Benetti <giulio.benetti at benettiengineering.com>

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
>   package/minicom/minicom.mk | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/package/minicom/minicom.mk b/package/minicom/minicom.mk
> index b81ee52120..5cd1d6b8b8 100644
> --- a/package/minicom/minicom.mk
> +++ b/package/minicom/minicom.mk
> @@ -11,12 +11,9 @@ MINICOM_SITE = \
>   MINICOM_LICENSE = GPL-2.0+
>   MINICOM_LICENSE_FILES = COPYING
>   MINICOM_CPE_ID_VENDOR = minicom_project
> -MINICOM_AUTORECONF = YES
>   
>   MINICOM_DEPENDENCIES = ncurses $(if $(BR2_ENABLE_LOCALE),,libiconv) \
>   	$(TARGET_NLS_DEPENDENCIES) host-pkgconf
> -# add host-gettext for AM_ICONV macro
> -MINICOM_DEPENDENCIES += host-gettext
>   
>   MINICOM_CONF_OPTS = \
>   	--enable-dfl-port=/dev/ttyS1 \
> 



More information about the buildroot mailing list