[Buildroot] [PATCH v2 1/2] package/strongswan: Add options to select EAP plugins

Arnout Vandecappelle arnout at mind.be
Mon Sep 27 16:56:22 UTC 2021



On 20/09/2021 17:28, Martin Elshuber wrote:
> Add options to chose EAP plugins.
> 
> Since the only plugin requiring libgmp is
> BR2_PACKAGE_STRONGSWAN_EAP_AKA_3GPP2, the selection of BR2_PACKAGE_GMP
> is moved down accordingly.
> 
> Signed-off-by: Martin Elshuber <martin.elshuber at theobroma-systems.com>
> 
> ---
> Changes v1 -> v2:
>    - use conditional defaults and mark as legacy
>    - drop 'ifeq ($(BR2_PACKAGE_STRONGSWAN_EAP),y)'
>    - fix title for BR2_PACKAGE_STRONGSWAN_EAP_DYNAMIC
> 
> Signed-off-by: Martin Elshuber <martin.elshuber at theobroma-systems.com>
> ---
>   package/strongswan/Config.in     | 89 +++++++++++++++++++++++++-------
>   package/strongswan/strongswan.mk | 40 +++++++-------
>   2 files changed, 87 insertions(+), 42 deletions(-)
> 
> diff --git a/package/strongswan/Config.in b/package/strongswan/Config.in
> index 368cd1ecc0..8eae568b6a 100644
> --- a/package/strongswan/Config.in
> +++ b/package/strongswan/Config.in
> @@ -75,34 +75,83 @@ config BR2_PACKAGE_STRONGSWAN_TNCCS_DYNAMIC
>   
>   config BR2_PACKAGE_STRONGSWAN_EAP
>   	bool "Enable EAP protocols"
> -	select BR2_PACKAGE_GMP
> -	help
> -	  Enable various EAP protocols:
> -	    - mschapv2
> -	    - tls
> -	    - ttls
> -	    - peap
> -	    - sim
> -	    - sim-file
> -	    - aka
> -	    - aka-3gpp2
> -	    - simaka-sql
> -	    - simaka-pseudonym
> -	    - simaka-reauth
> -	    - identity
> -	    - md5
> -	    - gtc
> -	    - tnc
> -	    - dynamic
> -	    - radius
>   
>   if BR2_PACKAGE_STRONGSWAN_EAP
>   
> +config BR2_PACKAGE_STRONGSWAN_EAP_SIM
> +	bool "Enable EAP-SIM"
> +	default y if BR2_PACKAGE_STRONGSWAN_EAP # legacy

  This is already inside if BR2_PACKAGE_STRONGSWAN_EAP, so the condition on the 
default is meaningless. Yann said something about this legacy stuff which I 
don't quite follow, since the BR2_PACKAGE_STRONGSWAN_EAP is not legacy. Yann, 
did you mean that BR2_PACKAGE_STRONGSWAN_EAP should be removed (i.e. moved to 
Config.in.legacy), or was it a mistake?


  Regards,
  Arnout

[snip]


More information about the buildroot mailing list