[Buildroot] [PATCH v2 2/3] package/smcroute: add sysv init script

Joachim Wiberg troglobit at gmail.com
Tue Sep 28 07:43:35 UTC 2021


On Sat, Sep 11, 2021 at 16:33, Arnout Vandecappelle <arnout at mind.be> wrote:
> On 30/08/2021 17:30, Joachim Wiberg wrote:
>  This is not how we usually write our start scripts, but I like it!

Thank you, I wasn't sure it would pass inspection :)

>> +{
>> +    start-stop-daemon -q -p "$PIDFILE" "$@"
>  Can't you pass the -x here as well (which makes sure that you actually kill the
> intended daemon in stop() and not some other random process that happens to have
> the same PID)?

Huh, from the usage text of start-stop-daemon it wasn't clear to me if
-x was reserved only for starting.  Thanks for alerting me to this!

>  Anyway, I applied as is.

Thanks, I'll push another bump later today, for the v2.5.3 release,
which will include a fix for -x as well.

Cheers
 /Joachim
 


More information about the buildroot mailing list