[Buildroot] [PATCH 1/1] package/dtbocfg: new package

Herve Codina herve.codina at bootlin.com
Tue Sep 28 15:40:56 UTC 2021


Hello Thomas,

On Tue, 28 Sep 2021 10:51:35 +0200
Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:

> > --- /dev/null
> > +++ b/package/dtbocfg/Config.in
> > @@ -0,0 +1,9 @@
> > +config BR2_PACKAGE_DTBOCFG
> > +	bool "dtbocfg"
> > +	help
> > +	  dtbocfg, which stands for Device Tree Blob Overlay Configuration
> > +          File System, was developed to serve as a userspace API of Device
> > +          Tree Overlay.  
> 
> There is an indentation issue here. The continuation lines should also
> have a one tab + 2 spaces indentation. I guess this is probably
> reported by "make check-package".

Indeed, will be fixed in v2.

> 
> > +DTBOCFG_VERSION = v0.0.9
> > +DTBOCFG_SITE = $(call github,ikwzm,dtbocfg,$(DTBOCFG_VERSION))  
> 
> This should be:
> 
> DTBOCFG_VERSION = 0.0.9
> DTBOCFG_SITE = $(call github,ikwzm,dtbocfg,v$(DTBOCFG_VERSION))
> 
> Indeed, we don't want the "v" prefix to appear in the version, so that
> the version can match with what release-monitoring.org reports.
> 

Right, will be fixed in v2.


Thanks for the review,

Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list