[Buildroot] [PATCH 1/1] linux:linux.mk: Add "firmware-imx" dependency if needed

[Charlie Leger]

Hi Baruch,

Le 04/05/2022 à 12:06, Baruch Siach a écrit :
> Hi Charlie,
>
> On Wed, May 04 2022, Charlie Leger wrote:
>> Thank you for your review
>>
>> Le 04/05/2022 à 11:43, Baruch Siach a écrit :
>> On Wed, May 04 2022, Leger Charlie wrote:
>>
>>   Since SDMA firmwares for imx[6,7,8] are now provided only by firmware-imx package and not linux-firmware
>>   package [1].
>> Linux build can failed if depending on firmware imx, so add firmware-imx dependency on linux if package is checked.
>>
>>
>> What build failure do you see when firmware-imx does not install before
>> kernel build? As far as I can see firmware files are only used at
>> run-time.
>>
>> Failure will happens only for specific kernel configuration which used "CONFIG_EXTRA_FIRMWARE" option [1], which allow to built-in firmware.
>> If firmware needed belongs to "firmware-imx" package, linux build will failed.
> Thanks for the clarification. The commit log should mention that
> firmware-imx is needed at build time for CONFIG_EXTRA_FIRMWARE.

I'm sorry for the dummy question... do I need to provide a v2 patch for it ?

> baruch
>
>> Charlie,
>>
>> https://cateee.net/lkddb/web-lkddb/EXTRA_FIRMWARE.html
>>
>> baruch
>>
>>   [1]http://lists.busybox.net/pipermail/buildroot/2021-January/603807.html
>>
>> Signed-off-by: Leger Charlie<c.leger at borea-dental.com>
>> ---
>>   linux/linux.mk | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/linux/linux.mk b/linux/linux.mk
>> index 7ff7b05042..e40672ceca 100644
>> --- a/linux/linux.mk
>> +++ b/linux/linux.mk
>> @@ -73,6 +73,7 @@ LINUX_INSTALL_IMAGES = YES
>>   LINUX_DEPENDENCIES = host-kmod \
>>   	$(if $(BR2_PACKAGE_INTEL_MICROCODE),intel-microcode) \
>>   	$(if $(BR2_PACKAGE_LINUX_FIRMWARE),linux-firmware) \
>> +	$(if $(BR2_PACKAGE_FREESCALE_IMX),firmware-imx) \
>>   	$(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb)
>>   
>>   # Starting with 4.16, the generated kconfig paser code is no longer
>

-- 

Charlie LEGER

Embedded Software Technician

Technicien Logiciel Embarqué

	Logo Borea
------------------------------------------------------------------------

6 allée Duke Ellington, Ester Technopole - 87100 Limoges - France

Téléphone +33(0)9 83 71 71 61 Mobile +33(0)6 98 30 25 64

Facebook <https://www.facebook.com/borea.dental> 	Linkedin 
<https://www.linkedin.com/company/borea-sas/> 	Instagram 
<https://www.instagram.com/borea_dental/> 	YouTube 
<https://www.youtube.com/channel/UCWFQZnXjcyDNcwObpPsXt6w/> 
www.borea-dental.com <https://www.borea-dental.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20220504/e71d8728/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wAuHlpVKCUAm7WpZ.png
Type: image/png
Size: 3273 bytes
Desc: not available
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20220504/e71d8728/attachment-0007.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8UoD0EgSaB7lSQ5G.png
Type: image/png
Size: 5259 bytes
Desc: not available
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20220504/e71d8728/attachment-0008.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Es2ikL52T7BzAIlF.png
Type: image/png
Size: 5234 bytes
Desc: not available
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20220504/e71d8728/attachment-0009.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ox0WjIXTWDkoYLuw.png
Type: image/png
Size: 384 bytes
Desc: not available
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20220504/e71d8728/attachment-0010.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1Spxztag3QdzDk7B.png
Type: image/png
Size: 398 bytes
Desc: not available
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20220504/e71d8728/attachment-0011.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3c0Q618S000Yk6co.png
Type: image/png
Size: 1510 bytes
Desc: not available
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20220504/e71d8728/attachment-0012.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ZJNrsmQElMBDi373.png
Type: image/png
Size: 1358 bytes
Desc: not available
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20220504/e71d8728/attachment-0013.png>