[Buildroot] [PATCH 1/1] package/wpewebkit: bump to version 2.36.2

[Michael Nosthoff]

Hi Adrian,

On Thursday, May 19, 2022 19:12 CEST, Adrian Perez de Castro <aperez at igalia.com> wrote:

> Hi,
> 
> On Thu, 19 May 2022 18:31:30 +0200 François Perrad <francois.perrad at gadz.org> wrote:
> > Le mer. 18 mai 2022 à 16:19, Adrian Perez de Castro <aperez at igalia.com> a
> > écrit :
> > 
> > > Bugfix release, mostly with build fixes, and an important fix for
> > > when using threaded rendering. Release notes:
> > >
> > >   https://wpewebkit.org/release/wpewebkit-2.36.2.html
> > >
> > > This release fails to build when X11 headers are not present, but there
> > > is already a fix accepted upstream and slated for inclusion in the next
> > > release in the series, so in the meantime imported it locally.
> > >
> > >
> > webkitgtk 2.36.1 (from BR 2022.05-rc1) has also this issue.
> > patch from https://bugs.webkit.org/show_bug.cgi?id=239039 solves it.
> 
> I was in the middle of preparing the 2.36.2 update for webkitgtk, which
> would include this patch as well; but then I found a different build
> issue. Then while looking into it Apple published a new list of security
> bugs, which means we need to make a new (which will be 2.36.3) for both
> ports including the fixes... so I have merged the build fix for the X11
> headers in the release branch and we won't even need to import the patch
> in Buildroot.
> 
> FWIW: let's not merge the 2.36.2 update for wpewebkit, because in a few
> days I will send anyway patches to go directly to 2.36.3
> 

I just tested the 2022.05-rc1 + this patch with my config.

The patch solved the X11 headers build error but I'm getting two other errors.

(This applies to 2.36.1 as well as 2.36.2, both patched)

The first one "disappears" when I issue "make wpewebkit" a second time, so I guess this
is a concurrency issue in the build setup:

[ 39%] Built target JavaScriptCore_CopyPrivateHeaders
Scanning dependencies of target jsc
make[4]: *** No rule to make target 'Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/LowLevelInterpreter.cpp.o', needed by 'bin/jsc'.  Stop.
make[4]: *** Waiting for unfinished jobs....
[ 39%] Building CXX object Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/__/jsc.cpp.o
make[3]: *** [CMakeFiles/Makefile2:794: Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/all] Error 2
make[3]: *** Waiting for unfinished jobs....
Scanning dependencies of target LowLevelInterpreterLib
[ 39%] Building CXX object Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/LowLevelInterpreter.cpp.o
[ 39%] Built target LowLevelInterpreterLib
[ 39%] Built target WebInspectorUI
make[2]: *** [Makefile:171: all] Error 2

and the build ultimately then later fails with this error:

[ 48%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-cbdfe323-42.cpp.o
In file included from platform/graphics/filters/FESpecularLighting.h:25,
                 from svg/SVGFESpecularLightingElement.h:25,
                 from ../../WebCore/DerivedSources/JSSVGFESpecularLightingElement.h:26,
                 from ../../WebCore/DerivedSources/JSSVGFESpecularLightingElement.cpp:22,
                 from ../../WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-119.cpp:5:
platform/graphics/filters/FELighting.h:72:41: error: ‘LightingData’ does not name a type
   72 |     inline void platformApplyNeon(const LightingData&, const LightSource::PaintingData&);
      |                                         ^~~~~~~~~~~~
make[4]: *** [Source/WebCore/CMakeFiles/WebCore.dir/build.make:5152: Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-119.cpp.o] Error 1

I tried to find it in the webkit bugtracker but was not successful. 

My WPE defconfig is 

BR2_PACKAGE_WPEWEBKIT=y
BR2_PACKAGE_WPEWEBKIT_SANDBOX=y

with the arm gcc 10.3 toolchain.

do you have any idea if this might be fixed in the upcoming 2.36.3?

Regards,
Michael