[Buildroot] [PATCH v1 1/4] board/zynqmp/post-build.sh: auto-generate extlinux.conf

[Luca Ceresoli]

Hi Neal,

On 25/05/22 15:33, Neal Frager wrote:
> Hi Luca,
> 
>>     FILE="${BOARD_DIR}/extlinux.conf"
>>     if test -f "$FILE"; then
>>         install -m 0644 -D "${BOARD_DIR}/extlinux.conf" "${BINARIES_DIR}/extlinux.conf"
> 
>> Right, but use "${FILE}" after -D.
> 
> I just want to make sure I am not missing something.  I have changed the script to the following:
> 
> if test -f "${FILE}"; then
>          install -m 0644 -D "${BOARD_DIR}/extlinux.conf" "${BINARIES_DIR}/extlinux.conf"
> 
> Is there another -D I need to add somewhere?

I didn't explain clearly, sorry. What I mean is quite trivial: you can
simplify this:

  install -m 0644 -D "${BOARD_DIR}/extlinux.conf" ...

with this:

  install -m 0644 -D "${FILE}" ...

-- 
Luca