[Buildroot] [External] Re: [PATCH v1 1/3] configs/zynqmp_zcu102_defconfig: bump to xilinx-v2024.1

[Frager, Neal]

Hi Brandon,

> -----Original Message-----
> From: Arnout Vandecappelle <arnout at mind.be>
> Sent: Thursday, June 6, 2024 1:09 PM
> To: Yann E. MORIN <yann.morin.1998 at free.fr>; Neal Frager
> <neal.frager at amd.com>
> Cc: ibai.erkiaga-elorza at amd.com; luca.ceresoli at bootlin.com; Maier, Brandon L
> Collins <Brandon.Maier at collins.com>; thomas.petazzoni at bootlin.com;
> buildroot at buildroot.org; michal.simek at amd.com
> Subject: [External] Re: [Buildroot] [PATCH v1 1/3]
> configs/zynqmp_zcu102_defconfig: bump to xilinx-v2024.1
>
>
>
> On 06/06/2024 17:25, Yann E. MORIN wrote:
> > However, while applying, I noticed that those boards do not have
> > BR2_DOWNLOAD_FORCE_CHECK_HASHES=y (so my post-apply hooks
> triggered).
> >
> > I wanted to add that and point to the newly introduced
> > board/xilinx/patches, but that will not be possible.
> >
> > Indeed, those defconfig use BR2_TARGET_UBOOT_ZYNQMP_PMUFW, and that
> is
> > added to the extra downloads, and we would need a hash for that file.
> >
> > But the filename is unversioned, which means that we can't differentiate
> > between pmufw.elf from yesterday, the one from today, and the one from
> > tomorrow.
> >
> > So, when arbitrary downloads of unversioned files are done in a
> > defconfig (or in a package enabled by tht defconfig), we will not be
> > able to force checking the hashes...
>
>   We could re-introduce the "none" hash method... But that is perhaps going in
> circles...

> What about the Yocto approach of appending the hash to the URI? E.g.

> BR2_TARGET_UBOOT_ZYNQMP_PMUFW=" https://github.com/Xilinx/soc-prebuilt-firmware/raw/xilinx_v2023.2/zcu102-zynqmp/pmufw.elf;sha256=1234..."

> Then pulling the hash off during download. That could also allow for checking other custom download types like applying the Linux RT_PREEMPT patches with LINUX_PATCHES.

I like this idea as it solves the issue with the new versal-firmware
as well.

https://patchwork.ozlabs.org/project/buildroot/patch/20240304074140.1537910-4-neal.frager@amd.com/
BR2_TARGET_VERSAL_FIRMWARE_PDI="https://github.com/Xilinx/soc-prebuilt-firmware/raw/xilinx_v2023.2/vck190-versal/vpl_gen_fixed.pdi;sha256=1234..."

Perhaps we can add this to the EXTRA_DOWNLOADS package variable?

Best regards,
Neal Frager
AMD