[Buildroot] [PATCH v1 1/1] package/hiredis: force cmake version 3.5

[Christian Stewart]

Hi all,

Marking this patch as Superceded. See below-

On Wed, Apr 2, 2025 at 2:59 AM Christian Stewart <christian at aperture.us> wrote:
> > The CMakeLists.txt within requires CMake 3.0.0, but newer CMake forces
> > at minimum version 3.5, leading to build failures:
> >
> > https://github.com/skiffos/SkiffOS/actions/runs/14208988354/job/39812576139#step:8:638
> >
> > Add the suggested build flag to force version 3.5.x and fix the error:
> >
> >   -DCMAKE_POLICY_VERSION_MINIMUM=3.5
> >
>
> I am now seeing this failure on other packages too on ubuntu-latest:
>
> https://github.com/skiffos/SkiffOS/actions/runs/14211566256/job/39819600184#step:8:26664
>
> Here is a failure with lzo as well as hiredis.
>
> I'm testing a edit to pkg-cmake.mk to add this to default options:
>
> # Some packages requires CMake 3.0.0 but latest CMake requires >=3.5
> # Set the policy version minimum to force these packages to 3.5 or greater.
> $(2)_CONF_OPTS += -DCMAKE_POLICY_VERSION_MINIMUM=3.5
>
> This would fix it across the board.

This worked, submitted a patch here:

https://patchwork.ozlabs.org/project/buildroot/patch/20250404182407.45244-1-christian@aperture.us/

Best regards,
Christian Stewart