[Buildroot] [PATCH 1/2] boot/xilinx-embeddedsw: fix menuconfig visualization

Arnout Vandecappelle arnout at rnout.be
Wed Apr 16 20:54:08 UTC 2025


On 17/03/2025 18:40, Luca Ceresoli via buildroot wrote:
> Due to how menuconfig works, a 'comment' entry following a 'config' entry
> prevents correct indentation of items depending on the 'config'
> entry. xilinx-embeddedsw currently shows as:
>
>    [*] xilinx-embeddedsw
>        *** xilinx-embeddedsw needs a bare metal toolchain for tuple microblazeel-xilinx-elf ***
>    (xilinx_v2024.2) xilinx-embeddedsw version (NEW)
>    [ ] versal plm (NEW)
>    [ ] versal psmfw (NEW)
>    [ ] zynqmp pmufw (NEW)
>    [ ] xilinx-prebuilt
>
> So the 'versal *' and 'zynqmp pmufw' items are not indented even though
> they should be.
>
> Do like most other Config.in files which have the 'comment' before the
> 'config' entry, makeing it render as expected:
>
>        *** xilinx-embeddedsw needs a bare metal toolchain for tuple microblazeel-xilinx-elf ***
>    [*] xilinx-embeddedsw
>    (xilinx_v2024.2) xilinx-embeddedsw version (NEW)
>    [ ]   versal plm (NEW)
>    [ ]   versal psmfw (NEW)
>    [ ]   zynqmp pmufw (NEW)
>    [ ] xilinx-prebuilt
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli at bootlin.com>

  Applied to 2025.02.x, thanks.

  Regards,
  Arnout

> ---
>   boot/xilinx-embeddedsw/Config.in | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/boot/xilinx-embeddedsw/Config.in b/boot/xilinx-embeddedsw/Config.in
> index b0691d7e7b753bba24820a9ec762c403213150d5..007b24e6685b63c15aed417e396e3320fe7bfb28 100644
> --- a/boot/xilinx-embeddedsw/Config.in
> +++ b/boot/xilinx-embeddedsw/Config.in
> @@ -1,3 +1,6 @@
> +comment "xilinx-embeddedsw needs a bare metal toolchain for tuple microblazeel-xilinx-elf"
> +	depends on BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH != "microblazeel-xilinx-elf"
> +
>   config BR2_TARGET_XILINX_EMBEDDEDSW
>   	bool "xilinx-embeddedsw"
>   	depends on BR2_aarch64
> @@ -14,9 +17,6 @@ config BR2_TARGET_XILINX_EMBEDDEDSW
>   	  Applications can be found on the Xilinx embeddedsw repo:
>   	  https://github.com/Xilinx/embeddedsw/tree/master/lib/sw_apps
>   
> -comment "xilinx-embeddedsw needs a bare metal toolchain for tuple microblazeel-xilinx-elf"
> -	depends on BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH != "microblazeel-xilinx-elf"
> -
>   if BR2_TARGET_XILINX_EMBEDDEDSW
>   
>   config BR2_TARGET_XILINX_EMBEDDEDSW_VERSION
>


More information about the buildroot mailing list