[Buildroot] [PATCH 1/2] package/linux-tools: perf: Fix _BIN_ARCH_EXCLUDE

[Arnout Vandecappelle]

On 18/02/2025 11:48, Niklas Cassel via buildroot wrote:
> From: Niklas Cassel <cassel at kernel.org>
>
> support/scripts/check-bin-arch has an option -i to exclude a path
> (or many paths by using -i multiple times).
>
> This was implemented in commit 01d90f0d093f ("spport/check-bin-arch:
> accept arbitrary per-package ignore paths").
>
> Looking at this feature (which hasn't changed since being added),
> we can see that check-bin-arch automatically adds a trailing slash
> to all entries specified using -i.
>
> Thus, specifying a path to a file, e.g.
> "/usr/libexec/perf-core/tests/pe-file.exe" will cause check-bin-arch
> to add "/usr/libexec/perf-core/tests/pe-file.exe/" to the IGNORES array.
>
> When running the main loop, the file
> "/usr/libexec/perf-core/tests/pe-file.exe" will thus not be ignored,
> since it will not trigger a match the pattern that was added to the
> IGNORES array ("/usr/libexec/perf-core/tests/pe-file.exe/").
>
> This means that the -i option in check-bin-arch only supports directories
> and not files.
>
> Fix the LINUX_TOOLS_BIN_ARCH_EXCLUDE in
> package/linux-tools/linux-tool-perf.mk.in to specify a directory, as the
> existing LINUX_TOOLS_BIN_ARCH_EXCLUDE can never have actually worked.
>
> Fixes: a7ad7816262d ("package/linux-tools: Exclude checking PE binaries from perf test")
> Signed-off-by: Niklas Cassel <cassel at kernel.org>

  Applied to 2025.02.x, 2024.11.x and 2024.02.x, thanks.

  Regards,
  Arnout

> ---
>   package/linux-tools/linux-tool-perf.mk.in | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/package/linux-tools/linux-tool-perf.mk.in b/package/linux-tools/linux-tool-perf.mk.in
> index df3030439e..d67318571a 100644
> --- a/package/linux-tools/linux-tool-perf.mk.in
> +++ b/package/linux-tools/linux-tool-perf.mk.in
> @@ -180,8 +180,7 @@ define PERF_INSTALL_REMOVE_SCRIPTS
>   endef
>   
>   LINUX_TOOLS_BIN_ARCH_EXCLUDE += \
> -	/usr/libexec/perf-core/tests/pe-file.exe \
> -	/usr/libexec/perf-core/tests/pe-file.exe.debug
> +	/usr/libexec/perf-core/tests/
>   endif
>   
>   define PERF_INSTALL_TARGET_CMDS