[Buildroot] [PATCH 1/1] support/download/dl-wrapper: add basic support for smb file download using curl

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sat Apr 19 13:59:49 UTC 2025


Hello Guillaume,

On Tue, 15 Apr 2025 12:50:01 -0400
Guillaume Chaye <guillaume.chaye at zeetim.com> wrote:

> This patch introduces a simpler approach to downloading files over the SMB protocol by using `curl` instead of `smbget`.
> 
> Please let me know if you prefer this method, or if you'd prefer the other implementation.

Could you describe a bit the use-case?

Overall, if curl is able to retrieve files via SMB, I guess this patch
is the simplest solution, compared to your other patch that uses smbget.

Note that this needs a better commit log: explanation of the use-case,
no reference to the "other implementation", and text wrapped to 80
columns.

Also, I'm pretty sure updating the Buildroot manual is needed to
document this additional site method.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com


More information about the buildroot mailing list