[Buildroot] [git commit branch/next] support/download/{curl, cvs, git, svn}: disable new shellcheck 0.9.0 errors
Peter Korsgaard
peter at korsgaard.com
Fri Feb 28 16:45:57 UTC 2025
commit: https://git.buildroot.net/buildroot/commit/?id=13deac1e39855cc8df1433299a6741a085afca46
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/next
As for SC1090 and SC2016 [1], disable SC1091 and SC2294 too since they
are now reported by shellcheck 0.9.0:
In support/download/curl line 42:
eval ${CURL} "${@}"
^--^ SC2294 (warning): eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string).
[1] bcee3ca6d66d30de4b0cd8186ce4c72020705df8
Signed-off-by: Romain Naour <romain.naour at smile.fr>
Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
---
support/download/curl | 1 +
support/download/cvs | 1 +
support/download/git | 2 ++
support/download/svn | 2 ++
4 files changed, 6 insertions(+)
diff --git a/support/download/curl b/support/download/curl
index bea4485a6c..2124fe7cad 100755
--- a/support/download/curl
+++ b/support/download/curl
@@ -39,6 +39,7 @@ _curl() {
# Note: please keep command below aligned with what is printed above
_plain_curl() {
# shellcheck disable=SC2086 # We want splitting
+ # shellcheck disable=SC2294
eval ${CURL} "${@}"
}
diff --git a/support/download/cvs b/support/download/cvs
index a6840fea7b..a52e543e44 100755
--- a/support/download/cvs
+++ b/support/download/cvs
@@ -47,6 +47,7 @@ _cvs() {
# Note: please keep command below aligned with what is printed above
_plain_cvs() {
# shellcheck disable=SC2086 # We really want word splitting in CVS
+ # shellcheck disable=SC2294
eval timeout 10m ${CVS} "${@}"
}
diff --git a/support/download/git b/support/download/git
index d49016e90c..8123bc3153 100755
--- a/support/download/git
+++ b/support/download/git
@@ -22,6 +22,7 @@ set -e
# GIT : the git command to call
# shellcheck disable=SC1090 # Only provides mk_tar_gz()
+# shellcheck disable=SC1091
. "${0%/*}/helpers"
# Save our path and options in case we need to call ourselves again
@@ -91,6 +92,7 @@ _git() {
# Note: please keep command below aligned with what is printed above
_plain_git() {
# shellcheck disable=SC2086 # We want word-splitting for GIT
+ # shellcheck disable=SC2294
eval GIT_DIR="${git_cache}/.git" ${GIT} "${@}"
}
diff --git a/support/download/svn b/support/download/svn
index 1decb2310b..ff33f1fa39 100755
--- a/support/download/svn
+++ b/support/download/svn
@@ -22,6 +22,7 @@ set -e
# SVN : the svn command to call
# shellcheck disable=SC1090 # Only provides mk_tar_gz()
+# shellcheck disable=SC1091
. "${0%/*}/helpers"
quiet=
@@ -52,6 +53,7 @@ _svn() {
# Note: please keep command below aligned with what is printed above
_plain_svn() {
# shellcheck disable=SC2086 # We want word-splitting for SVN
+ # shellcheck disable=SC2294
eval ${SVN} "${@}"
}
More information about the buildroot
mailing list