[Buildroot] [PATCH RESEND 1/2] package/libldns: add an option to build and install drill

[Alexis Lothoré]

Hi Thomas,

On Fri Oct 17, 2025 at 8:46 AM CEST, Thomas Petazzoni wrote:
> Hello Alexis,
>
> Thanks for the patch!
>
> On Thu, 16 Oct 2025 17:27:02 +0200
> Alexis Lothoré <alexis.lothore at bootlin.com> wrote:
>
>> The libldns library also comes with a CLI tool named drill, allowing to
>> perform DNS requests. Drill build is currently disabled by default.
>> 
>> Add a KConfig option to allow building and installing drill tool. Set
>> the default value to n to preserve the current behavior. Similarly to
>> linktest (see the comment in the .mk), drill fails to build correctly as
>> a static binary, so make the new option depend on non-static build.
>
> Missing SoB.

I'm note sure how I could have messed up this one... I'll fix that and the
points raised below, thanks.

Alexis
>> diff --git a/package/libldns/Config.in b/package/libldns/Config.in
>> index 696fec97b59857fbd99bdcaababa09d49774f3ae..7a169c495281be01b2ee724fd2f9e27b83f5e2ec 100644
>> --- a/package/libldns/Config.in
>> +++ b/package/libldns/Config.in
>> @@ -8,3 +8,17 @@ config BR2_PACKAGE_LIBLDNS
>>  	  experimental software for current Internet Drafts.
>>  
>>  	  http://www.nlnetlabs.nl/projects/ldns
>> +
>> +if BR2_PACKAGE_LIBLDNS
>> +
>> +config BR2_PACKAGE_LIBLDNS_DRILL
>> +	bool "drill binary"
>> +	default n
>
> default n is the default, so it's not needed.
>
>> +	depends on !BR2_STATIC_LIBS
>> +	help
>> +	  Install the drill binary
>> +
>> +comment "drill needs dynamic library"
>
> comment "drill needs a toolchain w/ dynamic library"
>
> Otherwise, looks good!
>
> Thomas




-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com