[Buildroot] [PATCH v2] package/bctoolbox: disable mbedtls support

[Thomas Petazzoni]

From: Thomas Petazzoni via buildroot <buildroot at buildroot.org>

Since mbedtls was bumped to version 3.6.3.1 in commit
3481a9643fc7223e400ed877f08ade34d44e6b78, the build of bctoolbox fails
as its mbedtls support is not compatible with mbedtls 3.x.

This issue is known upstream:

  https://github.com/BelledonneCommunications/bctoolbox/issues/19

and is not fixed, even in newer version of bctoolbox. So for the time
being, simply disable mbedtls support in bctoolbox.

Fixes:

  https://autobuild.buildroot.org/results/7af784cb60b0ec5e5bd0e0915ce6827f69f4bb97/

Newer versions of bctoolbox have fixed support for mbedtls 3.x,
however:

1. They require mbedtls to be built with the MBEDTLS_THREADING_ALT
   threading model, which is incompatible with the
   MBEDTLS_THREADING_PTHREAD threading model with which we are currently
   building mbedtls.

2. The bctoolbox project itself has been archived, and merged into
   linphone itself, making the work on bctoolbox version bump not very
   useful/relevant.

Disabling mbedtls support is therefore the most immediate solution to
fix the build issue.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
---
v1 -> v2: improve commit log to explain why this patch is the right
solution.
---
 package/bctoolbox/bctoolbox.mk | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/package/bctoolbox/bctoolbox.mk b/package/bctoolbox/bctoolbox.mk
index ac9361026f..db545311fd 100644
--- a/package/bctoolbox/bctoolbox.mk
+++ b/package/bctoolbox/bctoolbox.mk
@@ -12,25 +12,23 @@ BCTOOLBOX_INSTALL_STAGING = YES
 
 # Set CMAKE_SKIP_RPATH to prevent bctoolbox from adding the rpath to
 # shared library.
+
+# We have to disable mbedtls support even though we have a mbedtls
+# package because bctoolbox is not compatible with mbedtls 3.x as of
+# version 4.4.8.
 BCTOOLBOX_CONF_OPTS = \
 	-DENABLE_POLARSSL=OFF \
 	-DENABLE_STRICT=OFF \
 	-DENABLE_TESTS_COMPONENT=OFF \
 	-DENABLE_TESTS=OFF \
-	-DCMAKE_SKIP_RPATH=ON
+	-DCMAKE_SKIP_RPATH=ON \
+	-DENABLE_MBEDTLS=OFF
 
 ifeq ($(BR2_PACKAGE_LIBICONV),y)
 BCTOOLBOX_DEPENDENCIES += libiconv
 BCTOOLBOX_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -liconv"
 endif
 
-ifeq ($(BR2_PACKAGE_MBEDTLS),y)
-BCTOOLBOX_DEPENDENCIES += mbedtls
-BCTOOLBOX_CONF_OPTS += -DENABLE_MBEDTLS=ON
-else
-BCTOOLBOX_CONF_OPTS += -DENABLE_MBEDTLS=OFF
-endif
-
 ifeq ($(BR2_STATIC_LIBS),y)
 BCTOOLBOX_CONF_OPTS += -DENABLE_SHARED=OFF -DENABLE_STATIC=ON
 else ifeq ($(BR2_SHARED_STATIC_LIBS),y)
-- 
2.51.0