[Buildroot] [PATCH 1/1] support/scripts/gen-bootlin-toolchains: avoid selecting _HAS_THREADS multiple times
Julien Olivain
ju.o at free.fr
Sun Sep 21 19:24:56 UTC 2025
On 21/09/2025 18:50, Thomas Petazzoni via buildroot wrote:
> On Sun, 21 Sep 2025 18:17:21 +0200
> Julien Olivain <ju.o at free.fr> wrote:
>
>> The Bootlin external toolchain file Config.in.options contains
>> multiple
>> occurrences of "select BR2_TOOLCHAIN_HAS_THREADS". See for example
>> [1].
>>
>> This file is generated by the support/scripts/gen-bootlin-toolchains
>> script from the information published at [2].
>>
>> Those multiple occurrences happens with toolchains having
>> BR2_TOOLCHAIN_HAS_THREADS_DEBUG and/or BR2_TOOLCHAIN_HAS_THREADS_NPTL.
>>
>> Since the script uses the startswith() method, the _HAS_THREADS
>> selection is also generated for _HAS_THREADS_DEBUG and
>> _HAS_THREADS_NPTL. See [3].
>>
>> This commit solve the issue by adding a '=' character to make sure the
>> test will be distinct from other strings having the same prefix.
>>
>> Note: there is no functional problem due to those multiple selections,
>> since it is allowed by Kconfig. This commit is simply cosmetic, for
>> correctness.
>>
>> [1]
>> https://gitlab.com/buildroot.org/buildroot/-/blob/2025.08/toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options#L167
>> [2] https://toolchains.bootlin.com/
>> [3]
>> https://gitlab.com/buildroot.org/buildroot/-/blob/2025.08/support/scripts/gen-bootlin-toolchains#L366
>>
>> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
>> Signed-off-by: Julien Olivain <ju.o at free.fr>
>
> Acked-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
Applied to master, thanks.
>
> Thanks a lot!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
More information about the buildroot
mailing list