[Buildroot] [PATCH] feat(package/poco): build package with cmake instead of make
Arnout Vandecappelle
arnout at rnout.be
Tue May 5 20:06:54 UTC 2026
Hi Stefan,
I was about to apply, but there's a problem.
On 26/04/2026 19:44, Preiss, Stefan via buildroot wrote:
> Currently when building with make, the cmake config files are not
> generated. This leads to problems when integrating the package in an
> application built with cmake.
We need your Signed-off-by here, with the same name and e-mail address as the
Author of the commit. This shows that you claim that you either hold the
copyright to this changeset or have the right to license it, and that you
license it under Buildroot's GPLv2. [1]
Also, the title line of the commit should start with package/poco: without feat().
> ---
> package/poco/poco.mk | 88 ++++++++++++++------------------------------
> 1 file changed, 27 insertions(+), 61 deletions(-)
>
> diff --git a/package/poco/poco.mk b/package/poco/poco.mk
> index fe1dd29855..c5f418a664 100644
> --- a/package/poco/poco.mk
> +++ b/package/poco/poco.mk
> @@ -9,7 +9,6 @@ POCO_SITE = $(call github,pocoproject,poco,poco-$(POCO_VERSION)-release)
> POCO_LICENSE = BSL-1.0
> POCO_LICENSE_FILES = LICENSE
> POCO_CPE_ID_VENDOR = pocoproject
> -POCO_INSTALL_STAGING = YES
I don't think this is supposed to have been removed?
Otherwise the changeset looks OK.
Unfortunately I cannot apply without your Signed-off-by, so I've marked the
patch as Changes Requested in patchwork.
Regards,
Arnout
[1] https://developercertificate.org/
[snip]
More information about the buildroot
mailing list