[Buildroot] [PATCH v4 1/2] package/mpd: remove unused, add mandatory configuration items

[Thomas Petazzoni]

Hello Andreas,

On Sat, Sep 05, 2026 at 06:02:52AM +0200, Andreas Ziegler wrote:
> The configuration file supplied by Buildroot is only a sample; it will
> not start MPD on a default installation. In a production build, a custom
> mpd.conf has to be supplied via rootfs overlay or on the target system.
> 
> Supply the necessary configuration items to start mpd in a default build,
> and discard unused customizations. 
> 
> Signed-off-by: Andreas Ziegler <br025 at umbiko.net>

Thanks for the new iteration.

> diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> index 1b6815e904..bbd6fc16e5 100644
> --- a/package/mpd/Config.in
> +++ b/package/mpd/Config.in
> @@ -119,7 +119,6 @@ config BR2_PACKAGE_MPD_LIBSNDFILE
>  
>  config BR2_PACKAGE_MPD_MAD
>  	bool "mad"
> -	default y

Why?

>  	select BR2_PACKAGE_MPD_ID3TAG
>  	select BR2_PACKAGE_LIBMAD
>  	help
> @@ -244,7 +243,6 @@ comment "Output plugins"
>  
>  config BR2_PACKAGE_MPD_ALSA
>  	bool "alsa"
> -	default y

Why?

These changes are not really explained in your commit message. Also
this change will break existing defconfigs that assume those options
"default y". Is it important to change this? (Even though I agree they
should not have been "default y" in the first place).

> diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
> index 4db0aee7cb..5852bbe73f 100644
> --- a/package/mpd/mpd.mk
> +++ b/package/mpd/mpd.mk
> @@ -347,8 +347,6 @@ endif
>  
>  define MPD_INSTALL_EXTRA_FILES
>  	$(INSTALL) -m 0644 -D package/mpd/mpd.conf $(TARGET_DIR)/etc/mpd.conf
> -	mkdir -p $(TARGET_DIR)/var/lib/mpd/music
> -	mkdir -p $(TARGET_DIR)/var/lib/mpd/playlists

Why is that no longer needed? Because of the configuration file
change? Or because it was bogus/useless anyway?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com